elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Disallow non-file characters in pipeline names

Open parkertimmins opened this issue 9 months ago • 5 comments

Pipeline names may currently contain several non-alpha characters, such as comma and asterisk. Pipelines with such names cannot be fetched by id from the GET _ingest/pipeline/ api as the comma is interpreted to mean multiple id queries, and the asterisk is treated as a star query. Thus these characters, along with other characters which are not allowed in index or alias names, should be disallowed from pipeline names.

closes https://github.com/elastic/elasticsearch/issues/104411

parkertimmins avatar May 14 '24 21:05 parkertimmins

Pinging @elastic/es-data-management (Team:Data Management)

elasticsearchmachine avatar May 15 '24 16:05 elasticsearchmachine

Hi @parkertimmins, I've created a changelog YAML for you.

elasticsearchmachine avatar May 15 '24 16:05 elasticsearchmachine

Should we consult the Backwards Compatability Committee (BCC) on this?

cc @dakrone

nielsbauman avatar May 15 '24 19:05 nielsbauman

This is definitely something we'd want to consider as breaking before merging (and should consult the BCC). Also (separately), I wouldn't consider this large enough to introduce a brand new exception, we could likely use IllegalArgumentException for this. We can use MetadataCreateIndexService.validateIndexOrAliasName for the validation and construction of the IllegalArgumentException (we do this in a few places in the code).

dakrone avatar May 15 '24 19:05 dakrone

I was thinking to discuss with the team whether or not this seemed breaking changy, but in that case I'll go ahead and open a BCC ticket.

parkertimmins avatar May 15 '24 20:05 parkertimmins

Closing this for now as it's been superseeded by https://github.com/elastic/elasticsearch/pull/114837

lukewhiting avatar Oct 15 '24 14:10 lukewhiting