elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Use the new FlatVectorsScorer

Open ChrisHegarty opened this issue 1 year ago • 8 comments

This commit removes the copy of the ScalarQuantizedVectorsWriter that we added in 8.14, in favour of a custom FlatVectorsScorer.

Previously we maintained the copy of the writer so that we could add a custom scorer implementation when merging scalar quantized vectors. This is not necessary now as we can provide a FlatVectorsScorer implementation that provides the custom scorer.

ChrisHegarty avatar May 13 '24 16:05 ChrisHegarty

Pinging @elastic/es-search (Team:Search)

elasticsearchmachine avatar May 13 '24 16:05 elasticsearchmachine

@elasticmachine retest this please

ChrisHegarty avatar May 13 '24 16:05 ChrisHegarty

https://github.com/apache/lucene/pull/13366

This fixes that tiny test vector failure.

benwtrent avatar May 13 '24 18:05 benwtrent

@elasticmachine retest this please

ChrisHegarty avatar May 16 '24 09:05 ChrisHegarty

@elasticmachine test this please

ChrisHegarty avatar May 16 '24 09:05 ChrisHegarty

@elasticmachine test this please

ChrisHegarty avatar May 16 '24 17:05 ChrisHegarty

@elasticmachine test this please

ChrisHegarty avatar May 16 '24 21:05 ChrisHegarty

@elasticmachine test this please

ChrisHegarty avatar May 16 '24 22:05 ChrisHegarty

@elasticmachine test this please

ChrisHegarty avatar May 17 '24 05:05 ChrisHegarty