elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

ESQL: fix csv-spec tests expecting a floating result

Open bpintea opened this issue 1 year ago • 7 comments

Description

Some tests expecting a floating point result can fail on equality matching. We should either include in the query a rounding call for them all, or fix the infra to do a range check instead of an exact one.

bpintea avatar May 13 '24 12:05 bpintea

Pinging @elastic/es-analytical-engine (Team:Analytics)

elasticsearchmachine avatar May 13 '24 12:05 elasticsearchmachine

Examples: https://gradle-enterprise.elastic.co/s/yke3pbfiqsvfo/console-log?page=5 https://gradle-enterprise.elastic.co/s/yjustunaoqnss/console-log?anchor=4650&page=5

bpintea avatar May 13 '24 12:05 bpintea

This problem also occurs with queries that create geo POINTs as output; didn't fail us any tests yet, but at least incurs some noise in PRs that touch geo optimizations, like here.

alex-spies avatar May 16 '24 12:05 alex-spies

IMHO it's hard to define a single rounding criterion that can be applied to all the spec tests, in some cases we really want to test that the result is really accurate. As a first step we could at least reduce the noise by manually rounding the most problematic cases

luigidellaquila avatar May 21 '24 08:05 luigidellaquila

Another similar one: https://gradle-enterprise.elastic.co/s/sagzdexxdymfw/tests/task/:qa:stateful:x-pack:plugin:esql:qa:server:single-node:javaRestTest/details/org.elasticsearch.xpack.esql.qa.single_node.EsqlSpecIT/test%20%7Bstats.DocsStatsSumNestedExpression%23%5Bskip:-8.12.99%2Creason:supported%20in%208.13%2B%5D%20ASYNC%7D?top-execution=1

nik9000 avatar May 29 '24 16:05 nik9000

Another one like that: https://gradle-enterprise.elastic.co/s/ciqv2teawnuhy/tests/task/:qa:stateful:x-pack:plugin:esql:qa:server:multi-node:javaRestTest/details/org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT/test%20%7Bk8s-metrics.TwoRatesWithBucket%20ASYNC%7D?top-execution=1

alex-spies avatar Jun 28 '24 07:06 alex-spies

Should be closed by https://github.com/elastic/elasticsearch/pull/110238

alex-spies avatar Jun 28 '24 15:06 alex-spies

Fixed in #110238

dnhatn avatar Jul 03 '24 21:07 dnhatn