elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Update node.asciidoc | english dialect clarity

Open anniegale9538 opened this issue 1 year ago • 2 comments

I noticed that "specialized" is used twice is this doc and "specialised" is also used once in this doc. I'd like to clarify the english dialect (American vs British) we want to use for consistency.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

anniegale9538 avatar Feb 14 '24 21:02 anniegale9538

❌ Author of the following commits did not sign a Contributor Agreement: f30494d886045a0eb98d7edf93992037f9f298f9

Please, read and sign the above mentioned agreement if you want to contribute to this project

Documentation preview:

github-actions[bot] avatar Feb 14 '24 21:02 github-actions[bot]

@anniegale9538 Is it definitely 8.12 you want to target here?

thecoop avatar Feb 21 '24 10:02 thecoop

Pinging @elastic/es-docs (Team:Docs)

elasticsearchmachine avatar Feb 21 '24 10:02 elasticsearchmachine

Pinging @elastic/es-core-infra (Team:Core/Infra)

elasticsearchmachine avatar Feb 21 '24 10:02 elasticsearchmachine

We normally use American spelling in our docs

thecoop avatar Feb 21 '24 10:02 thecoop

Thanks for the PR @anniegale9538, however as this is a very minor change, following our contributing guidelines we don't normally accept PRs like this from outside engineering. However, if you find several of these and bundle them up in a PR (and get the CLA check fixed for your account) we would be happy to accept it.

thecoop avatar Mar 21 '24 15:03 thecoop