elasticsearch
elasticsearch copied to clipboard
adding field data test
noticed that there was not a unit test for the rescore plugin example covering the "fieldFactor" mode of operation that pulls data from document fields for use in rescore operation, this test helped me to understand it a bit better, and actually helps reveal some oddities about the example that future developers might not have to wonder about for so many hours.
best of luck and happy coding jw
💚 CLA has been signed
Pinging @elastic/es-search (Team:Search)
@elasticmachine update branch
run elasticsearch-ci*
buildkite test this
@forjonathanwilsonyahoocom CI is happy with the change :D. CLA is still not happy :(. I am digging around to see whats going on. One issue might be the email used when signing the CLA might not be present on your github account. I am trying to see if the cause is something else.
@forjonathanwilsonyahoocom I have found the problem, the email address for the CLA is indeed different than the commit authorship. Is it possible to sign the CLA again, but with the email associated with your github profile & commit authorship?
no problem, ill do so
@benwtrent resigned, looks like my work email was attached to that commit
@elasticmachine update branch
buildkite test this
@elasticmachine update branch
buildkite test this
@forjonathanwilsonyahoocom thank you so much for your contribution!!! Giving plugin authors more examples is exceptionally useful and will help folks in the future. 🎉🎉🎉