elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

adding field data test

Open forjonathanwilsonyahoocom opened this issue 1 year ago • 2 comments

noticed that there was not a unit test for the rescore plugin example covering the "fieldFactor" mode of operation that pulls data from document fields for use in rescore operation, this test helped me to understand it a bit better, and actually helps reveal some oddities about the example that future developers might not have to wonder about for so many hours.

best of luck and happy coding jw

💚 CLA has been signed

Pinging @elastic/es-search (Team:Search)

elasticsearchmachine avatar Feb 14 '24 20:02 elasticsearchmachine

@elasticmachine update branch

benwtrent avatar Feb 23 '24 12:02 benwtrent

run elasticsearch-ci*

benwtrent avatar Feb 23 '24 13:02 benwtrent

buildkite test this

benwtrent avatar Feb 23 '24 13:02 benwtrent

@forjonathanwilsonyahoocom CI is happy with the change :D. CLA is still not happy :(. I am digging around to see whats going on. One issue might be the email used when signing the CLA might not be present on your github account. I am trying to see if the cause is something else.

benwtrent avatar Feb 23 '24 14:02 benwtrent

@forjonathanwilsonyahoocom I have found the problem, the email address for the CLA is indeed different than the commit authorship. Is it possible to sign the CLA again, but with the email associated with your github profile & commit authorship?

benwtrent avatar Feb 23 '24 14:02 benwtrent

no problem, ill do so

@benwtrent resigned, looks like my work email was attached to that commit

@elasticmachine update branch

benwtrent avatar Feb 26 '24 16:02 benwtrent

buildkite test this

benwtrent avatar Feb 26 '24 16:02 benwtrent

@elasticmachine update branch

benwtrent avatar Feb 26 '24 16:02 benwtrent

buildkite test this

benwtrent avatar Feb 26 '24 16:02 benwtrent

@forjonathanwilsonyahoocom thank you so much for your contribution!!! Giving plugin authors more examples is exceptionally useful and will help folks in the future. 🎉🎉🎉

benwtrent avatar Feb 27 '24 09:02 benwtrent