elasticsearch icon indicating copy to clipboard operation
elasticsearch copied to clipboard

Published 20 hours ago • verified publisher icon elastic

ESQL: missing equals and hashCode for some functions

Open alex-spies opened this issue 1 year ago • 3 comments

Some functions are missing correct implementations for equals and hashCode. This applies at least to

  • ~~DateDiff~~ Update: This one is actually fine.
  • DateExtract and other ConfigurationFunctions (we could just implement this for ConfigurationFunction in this case).

Other functions may need to be checked as well.

alex-spies avatar Jan 16 '24 10:01 alex-spies

Pinging @elastic/es-analytics-geo (Team:Analytics)

elasticsearchmachine avatar Jan 16 '24 10:01 elasticsearchmachine

Interesting that this hasn't bit us. I know we have a ton of function test case utilities, but they don't actually use equals and hashCode - they are more about building the function and running it.

nik9000 avatar Jan 17 '24 13:01 nik9000

Pinging @elastic/es-analytical-engine (Team:Analytics)

elasticsearchmachine avatar Apr 23 '24 13:04 elasticsearchmachine