elasticsearch-rs icon indicating copy to clipboard operation
elasticsearch-rs copied to clipboard

Published 20 hours ago • verified publisher icon elastic

[INFRA] Setting up pull request CI

Open russcam opened this issue 5 years ago • 6 comments

Currently, there are a couple of basic checks in place for PRs:

  1. CLA check
  2. Clippy check

In line with other official client repositories, a Continuous Integration should be configured to:

  1. run unit tests
  2. run integration tests
  3. check for dead links in documentation

on PRs.

russcam avatar Jan 24 '20 07:01 russcam

appears in a puff of smoke

Did someone say infra?

mindbat avatar Jan 24 '20 17:01 mindbat

Yes @mindbat 😃 Clients typically use https://clients-ci.elastic.co/ for running the YAML spec tests (#19). I was thinking that GitHub actions might work better for the above?

russcam avatar Jan 27 '20 23:01 russcam

I was thinking that GitHub actions might work better for the above?

I'm not as familiar with those, though I know the @elastic/infra-automation team has been experimenting with them.

But as far as running unit & integration tests, then posting results back on the PR, clients-ci should work fine for that :)

mindbat avatar Jan 28 '20 00:01 mindbat

I vote for GitHub actions 😄

It is really handy to have it built into the GitHub UI for open source projects...

mwilliammyers avatar Jan 30 '20 06:01 mwilliammyers

Actions are great - there are some pretty good rust ones https://github.com/actions-rs?type=source if you haven't already come across those

bryantbiggs avatar Jan 30 '20 11:01 bryantbiggs

Clients CI environment now runs all yaml tests for a PR, but I think it would be useful to run all the tests in the elasticsearch create

russcam avatar Sep 23 '20 10:09 russcam