elasticsearch-rails icon indicating copy to clipboard operation
elasticsearch-rails copied to clipboard
verified publisher icon elastic

Deprecation warning in Rails 7.1 (support Rails 7.2)

Open N0xFF opened this issue 2 years ago • 4 comments

Rails 7.1.3 log:

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. color("my text", :red, bold: true)).

Related PRs:

  • https://github.com/elastic/elasticsearch-rails/pull/1067
  • https://github.com/elastic/elasticsearch-rails/pull/1058

N0xFF avatar Feb 08 '24 15:02 N0xFF

This is open since february. Rails 7.2 has been released. It would be great if this gem would get ready for Rails 7.2

tmaier avatar Sep 04 '24 22:09 tmaier

Looks like they fixed it in elasticsearch-rails v8.0.0 but Elasticsearch 7 maintained until 9 version.

@picandocodigo can we release the fix in 7.x branch?

N0xFF avatar Sep 05 '24 02:09 N0xFF

I think @r-plus created a Pull Request for this at #1086

Can this be reviewed and released?

tmaier avatar Jan 29 '25 00:01 tmaier

As a elastic.co customer, I raised now a support request. Case 500Vv00000IA0ArIAL

tmaier avatar Feb 05 '25 23:02 tmaier