elasticsearch-rails icon indicating copy to clipboard operation
elasticsearch-rails copied to clipboard

Use self.client instead of client

Open adibsaad opened this issue 3 years ago • 3 comments
trafficstars

Should fix https://github.com/elastic/elasticsearch-rails/issues/1004 (also mentioned here https://github.com/elastic/elasticsearch-ruby/issues/1344#issuecomment-1017176417)

When deleting an index that doesn't exist, the exception handler references client but I think it should be referencing self.client

adibsaad avatar Jun 09 '22 19:06 adibsaad

💚 CLA has been signed

Hello, can someone review this ? I have the same issue

Lolote13 avatar Jul 03 '22 10:07 Lolote13

up ?

sebfie avatar Sep 16 '22 07:09 sebfie

I've catch error #1004

Added gem 'elasticsearch-rails', github: 'adibsaad/elasticsearch-rails', branch: 'patch-1' instead of main version.

Unfortunately, the error is still the same.

NoMethodError: undefined method `transport' for #<Elasticsearch::Transport::Transport::HTTP::Faraday:0x0000564e78127498>
/bundle/ruby/2.7.0/bundler/gems/elasticsearch-rails-a0b81a691fd3/elasticsearch-model/lib/elasticsearch/model/indexing.rb:293:in `rescue in delete_index!'
/bundle/ruby/2.7.0/bundler/gems/elasticsearch-rails-a0b81a691fd3/elasticsearch-model/lib/elasticsearch/model/indexing.rb:289:in `delete_index!'
/bundle/ruby/2.7.0/bundler/gems/elasticsearch-rails-a0b81a691fd3/elasticsearch-model/lib/elasticsearch/model/indexing.rb:248:in `create_index!'

kalashnikovisme avatar Oct 03 '22 01:10 kalashnikovisme