elasticsearch-rails icon indicating copy to clipboard operation
elasticsearch-rails copied to clipboard

Fix error while doing bundle error. Branch name is changed from maste…

Open sonianand11 opened this issue 3 years ago • 5 comments
trafficstars

  • Since the branch name is changed to main from master, bundle install was giving an error in elasticsearch-persistance app which is fixed with specifying branch name
  • Fix the error undefined method each_with_hit for Hash

sonianand11 avatar Dec 27 '21 21:12 sonianand11

💚 CLA has been signed

@picandocodigo can you please review this PR?

sonianand11 avatar Dec 28 '21 19:12 sonianand11

Hi @sonianand11, Thanks for submitting this PR. GitHub has some features in place to redirect to main when there's a request to master and it seems to be working as expected with bundler for me. What error were you getting when running bundle install and what versions of Bundler and Ruby were you using?

picandocodigo avatar Dec 29 '21 09:12 picandocodigo

@picandocodigo Thank you for quick response. Current ruby version is ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux] I am using bundler version 2.1.4 and here is the error

Fetching https://github.com/elastic/elasticsearch-rails.git
fatal: Needed a single revision
Git error: command `git rev-parse --verify master` in directory

I am executing bundle install inside examples directory i.e. elasticsearch-rails/elasticsearch-persistence/examples/notes

If I do git branch in elasticsearch-rails/elasticsearch-persistence/examples/notes it is showing main branch instead of master since we already have changed that.

sonianand11 avatar Dec 29 '21 17:12 sonianand11

Hi @sonianand11. If you update Bundler to a version >= 2.2.5, it will just work and there's no need to change the Gemfile.

deivid-rodriguez avatar Mar 20 '22 11:03 deivid-rodriguez