elasticsearch-php icon indicating copy to clipboard operation
elasticsearch-php copied to clipboard

Published 20 hours ago • verified publisher icon elastic

Improvements about fixtures and assertion equals

Open peter279k opened this issue 5 years ago • 2 comments
trafficstars

Changed log

  • Using the assertSame to replace assertEquals to make assertion equals strict.
  • According to the PHPUnit fixtures reference, it should be the protected function setUp and protected function tearDown methods.

BTW, I've CLA sigined via this site, but the CLA checking service still say I don't do CLA sign.

I think this checking service will not recheck the latest CLA sign...

peter279k avatar Aug 21 '20 09:08 peter279k

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine avatar Aug 21 '20 09:08 elasticmachine

💚 CLA has been signed

cla-checker-service[bot] avatar Aug 21 '20 09:08 cla-checker-service[bot]

Is there any reason why this PR get closed 🤔 ?

peter279k avatar Aug 24 '22 15:08 peter279k