elasticsearch-net icon indicating copy to clipboard operation
elasticsearch-net copied to clipboard

8.15.6: TypeMappingDescriptor Dynamic Feedback

Open niemyjski opened this issue 5 months ago • 3 comments

Elastic.Clients.Elasticsearch version: 8.15.6

Elasticsearch version: 8.15.1

.NET runtime version: 8.x

Operating system version: Any

Description of the problem including expected versus actual behavior:

The new generated api has some pain points on upgrading I felt might have been overlooked but would be easier on those upgrading.

The existing mappings had .Dynamic() but the new one requires you to specify an enum .Dynamic(DynamicMapping.True). I don't know why this couldn't just be the default. You are not going to do .Dynamic(DynamicMapping.None) as you would just omit it. I get there are other enum values but seems like those could be specified. We have tons and tons of theses that we had to bulk replace.

The same feedback goes for other areas like .TrackTotalHits(true) -> .TrackTotalHits(new TrackHits(true)))

Expected behavior Smart defaults would go a long way to not breaking existing api's.

Reference: https://github.com/FoundatioFx/Foundatio.Parsers/pull/84

niemyjski avatar Sep 13 '24 21:09 niemyjski