elasticsearch-labs icon indicating copy to clipboard operation
elasticsearch-labs copied to clipboard

Unifying Elastic vector database and LLM functions for intelligent query Part 2

Open sunilemanjee opened this issue 7 months ago • 1 comments

Related to topic: https://github.com/orgs/elastic/projects/1446/views/1?filterQuery=llm+function&pane=issue&itemId=107821356&issue=elastic%7Csearch-labs-elastic-co%7C1535

I wrote part one here: https://www.elastic.co/search-labs/blog/llm-functions-elasticsearch-intelligent-query

This is part 2. Uses a different dataset (homes/properties instead of hotels) with the same intelligent query pattern identified in part 1. Additional part two leverages serverless and ships with a UI for search.

sunilemanjee avatar Apr 24 '25 19:04 sunilemanjee

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/453

gitnotebooks[bot] avatar Apr 24 '25 19:04 gitnotebooks[bot]

@sunilemanjee I've spotted a couple of things:

  1. Can you change the example to use endpoint instead of Cloud ID? That has been the standard for a while.
  2. Can you also list the prerequisites need at the top of the notebook as well. It needs several different endpoints and keys, so having it all at the start with any useful setup guides (in addition to what you have in the accompanying blog) would be useful.
  3. Any change you can update the piece to at least 8.18? I get that 8.17 was the latest at the time of writing.
  4. Update the Google Collab link which is still pointing to the part 1 notebook.

carlyrichmond avatar Jul 18 '25 09:07 carlyrichmond

@carlyrichmond i'm slightly confused. There is no notebook in this demo or article

Can you change the example to use endpoint instead of Cloud ID? That has been the standard for a while.

  • Where is cloudID? the demo uses API key

Can you also list the prerequisites need at the top of the notebook as well. It needs several different endpoints and keys, so having it all at the start with any useful setup guides (in addition to what you have in the accompanying blog) would be useful.

  • I don't have a notebook for this article.

Any change you can update the piece to at least 8.18? I get that 8.17 was the latest at the time of writing. Update the Google Collab link which is still pointing to the part 1 notebook.

  • again no notebook for this article

sunilemanjee avatar Jul 20 '25 21:07 sunilemanjee

@sunilemanjee I see in the commit history that this PR is picking up commits on the following notebook:

supporting-blog-content/unifying-elastic-vector-database-and-llms-for-intelligent-query/Unifying_Elastic_Vector_Database_and_LLMs_for_Intelligent_Query_Part_2.ipynb

Is that not correct?

carlyrichmond avatar Jul 21 '25 01:07 carlyrichmond

@carlyrichmond this article does not have a notebook. all the code is referenced within the code repo @justincastilla has been reviewing.

sunilemanjee avatar Aug 01 '25 08:08 sunilemanjee

@sunilemanjee that may be the case, but this PR that I am commenting on here has changes to a notebook showing in the commit history:

Screenshot 2025-08-01 at 09 20 17

Perhaps something is linked incorrectly, or small changes have been made to a notebook for a different article?

@justincastilla can you sync with @sunilemanjee and get this closed out please? It's been sitting quite a while and we need to try and close it out.

carlyrichmond avatar Aug 01 '25 08:08 carlyrichmond

Given this notebook isn't needed for the piece I'm closing it without merging. Feel free to reopen if it's needed.

carlyrichmond avatar Sep 02 '25 16:09 carlyrichmond