elasticsearch-labs icon indicating copy to clipboard operation
elasticsearch-labs copied to clipboard

add alibabacloud ai search notebook

Open Huaixinww opened this issue 1 year ago • 5 comments

Related to https://www.elastic.co/guide/en/elasticsearch/reference/master/infer-service-alibabacloud-ai-search.html This PR adds a Jupyter notebook that contains an end-to-end example of using the Inference API with the AlibabaCloud AI Search service.

Huaixinww avatar Sep 03 '24 12:09 Huaixinww

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/324

gitnotebooks[bot] avatar Sep 03 '24 12:09 gitnotebooks[bot]

@elastic/search-experiences-team please review

serenachou avatar Sep 03 '24 23:09 serenachou

💚 CLA has been signed

Ah you also need to run pre-commit, to format the notebook https://github.com/elastic/elasticsearch-labs/blob/main/CONTRIBUTING.md#pre-commit-hook

joemcelroy avatar Sep 18 '24 09:09 joemcelroy

Ah you also need to run pre-commit, to format the notebook https://github.com/elastic/elasticsearch-labs/blob/main/CONTRIBUTING.md#pre-commit-hook

Thank you for the reminder! I've already run the pre-commit hook to format the notebook. Let me know if you need anything else!

Huaixinww avatar Sep 19 '24 02:09 Huaixinww

This notebook isn't passing some of the checks but I'm happy to merge this after. I've found this to be helpful in the past when some of my code was in a similar state:

python -m venv .venv
.venv/bin/pip install -qqq -r requirements-dev.txt
.venv/bin/pre-commit install

@Huaixinww feel free to ping me if you need any help here.

JessicaGarson avatar Nov 19 '24 14:11 JessicaGarson

This notebook isn't passing some of the checks but I'm happy to merge this after. I've found this to be helpful in the past when some of my code was in a similar state:

python -m venv .venv
.venv/bin/pip install -qqq -r requirements-dev.txt
.venv/bin/pre-commit install

@Huaixinww feel free to ping me if you need any help here.

Hi @JessicaGarson, thanks a lot for ur suggestion! I've already run the pre-commit, the pre-commit check is successful. This notebook isn't passing some of the checks because I didn't set the ELASTIC_USER and ELASTIC_PASSWORD in my demo, I want to know how to pass this check? should I add fake ELASTIC_USER and ELASTIC_PASSWORD?

Huaixinww avatar Nov 20 '24 08:11 Huaixinww

because this notebook relies on an alibaba account, we cannot rely on our automated tests to validate this notebook from regressions. This notebook needs to be excluded in https://github.com/elastic/elasticsearch-labs/blob/main/bin/find-notebooks-to-test.sh#L3

@JessicaGarson worth adding this in the contribute guide for when contributing notebooks to notebooks folder.

joemcelroy avatar Nov 20 '24 08:11 joemcelroy

pushed up to exclude it from the CI test script and also moved the notebook into integrations.

joemcelroy avatar Nov 20 '24 19:11 joemcelroy