elasticsearch-java icon indicating copy to clipboard operation
elasticsearch-java copied to clipboard
verified publisher icon elastic

Add improvements to response _DESERIALIZER

Open shinsj4653 opened this issue 1 year ago • 2 comments

This PR adds a number of enhancements to several response classes.

co.elastic.clients.elasticsearch.security:

  • DisableUserResponse
  • EnableUserResponse
  • ChangePasswordResponse

co.elastic.clients.elasticsearch.indices:

  • SimulateIndexTemplateResponse

For the response that returns an empty object, or has a possibility according to the server-side code, _DESERIALIZER should use emptyObject(T) from the JsonpDeserializer.

For more detailed specifications regarding this PR, please refer to https://github.com/elastic/elasticsearch-java/issues/718#issuecomment-2027988172.

shinsj4653 avatar Mar 30 '24 09:03 shinsj4653

Looks fine to me at a glance, but unfortunately not in a position to test ATM and don't have permissions to make a useful review.

henryptung avatar Apr 07 '24 01:04 henryptung

Appreciate for the feedback! I hope to get further comments from this open source administrators.

shinsj4653 avatar Apr 15 '24 07:04 shinsj4653