elasticsearch-dsl-py icon indicating copy to clipboard operation
elasticsearch-dsl-py copied to clipboard

Fix DeprecationWarning's from elasticsearch-py.

Open arnau126 opened this issue 2 years ago • 3 comments

See https://github.com/elastic/elasticsearch-py/issues/1698 for more information. Fixes #1551 .

arnau126 avatar Jan 13 '22 17:01 arnau126

💚 CLA has been signed

We can also do something like:

        if elasticsearch.__version__ >= (7, 14, 0):
            key = 'document'
        else:
            key = 'body'
        meta = es.index(
            index=self._get_index(index),
            **{key: self.to_dict(skip_empty=skip_empty)},
            **doc_meta
        )

arnau126 avatar Jan 19 '22 08:01 arnau126

@sethmlarson Please, let me know if anything else is required. (I've rebased the branch).

arnau126 avatar Oct 07 '22 18:10 arnau126

Could we get a new release with this patch? We are drowning in deprecation warnings 😢

Happy to help if anything else needs to be done before the release, let me know!

anze3db avatar Feb 24 '23 13:02 anze3db

Thanks for this, I've created a separate PR which fixed the deprecations for all APIs. The fix is available on v7.4.1 on PyPI.

sethmlarson avatar Mar 01 '23 21:03 sethmlarson