elastic-charts icon indicating copy to clipboard operation
elastic-charts copied to clipboard

[Flamechart] Add button to expand the flamechart covering the full screen

Open cauemarcondes opened this issue 8 months ago • 4 comments

Is your feature request related to a problem? Please describe. It would be great to be able to maximize the Profiling flamegraph, sometimes the graph is too big and it's difficult to navigate through it.

Image

Describe the solution you'd like Similar to the EuiDataGrid, it would be great to be able to toggle a maximize button on the top-right corner of the flamegraph.

Describe alternatives you've considered N/A

Additional context N/A

Kibana Cross Issues N/A

Checklist

Delete any items that are not applicable to this feature request.

  • [x] this request is checked against already exist requests
  • [x] every related Kibana issue is listed under Kibana Cross Issues list
  • [x] kibana cross issue tag is associated to the issue if any kibana cross issue is present

cauemarcondes avatar Mar 19 '25 16:03 cauemarcondes

If we thing that the maximize logic should not be handled by the flamechart component, I can implement it myself on the Profiling UI.

cauemarcondes avatar Mar 19 '25 16:03 cauemarcondes

What do you mean by maximize? expanding to cover the full screen? if that the case I believe this should be handled by the consumer so your Profiling UI

markov00 avatar Mar 19 '25 17:03 markov00

What do you mean by maximize? expanding to cover the full screen?

Yes, I meant enter in full screen mode.

I asked that because maybe this would be a feature that could belong to the flamechart, like it belongs to the EuiDataGrid.

cauemarcondes avatar Mar 20 '25 18:03 cauemarcondes

I asked that because maybe this would be a feature that could belong to the flamechart, like it belongs to the EuiDataGrid.

To me this sounds like the way to go. I can't imagine any flamegraph user not wanting this functionality. Any user spending significant time with flamegraphs would love the option to maximize the information shown and reduce the amount of scrolling and zooming one has to do.

christos68k avatar Mar 22 '25 02:03 christos68k