elastic-charts icon indicating copy to clipboard operation
elastic-charts copied to clipboard

feat(Legend): change click on item behaviour

Open dej611 opened this issue 9 months ago • 2 comments

Summary

Clicking on a legend item has been improved to isolate a series on first click, show all series on second click. Also, when clicking on a hidden series now will add the selected series into the visible set.

BREAKING CHANGE

The modifier key has been changed to CTRL (or CMD on Mac) from SHIFT. The SHIFT key will no longer have any effect on click.

Details

A full description of the new behaviour:

First click isolates selected element, then behave according to context (if single element is selected, restore all, otherwise toggle on off).

Checklist

  • [x] The proper chart type label has been added (e.g. :xy, :partition)
  • [x] The proper feature labels have been added (e.g. :interactions, :axis)
  • [x] Unit tests have been added or updated to match the most common scenarios

dej611 avatar May 08 '24 14:05 dej611

buildkite update screenshots

dej611 avatar May 09 '24 12:05 dej611

buildkite update screenshots

dej611 avatar May 14 '24 09:05 dej611

Now all checks are passing @markov00 . It was a wrong casting in the playwright test.

dej611 avatar May 14 '24 10:05 dej611

buildkite update screenshots

dej611 avatar May 14 '24 10:05 dej611

buildkite update screenshots

dej611 avatar May 14 '24 10:05 dej611

buildkite update screenshots

dej611 avatar May 14 '24 13:05 dej611

buildkite update screenshots

dej611 avatar May 14 '24 13:05 dej611

buildkite update screenshots

dej611 avatar May 14 '24 14:05 dej611

All screenshots are now being checked and resolved with no changes from the main branch.

dej611 avatar May 14 '24 14:05 dej611