elastic-charts icon indicating copy to clipboard operation
elastic-charts copied to clipboard

Contrast ratio on bar chart hover in elastic-charts

Open ghudgins opened this issue 3 years ago • 5 comments

Description The contrast on bar chart hover in elastic-charts is very hard to see. It's bad on both themes but it's particularly bad on the dark themes (see screenshot).

In 7.15 Kibana added the ability to synchronize hover across more chart types. TSVB previously had this functionality and made the hover red, however, because the newer vis editors are conforming to EUI, the color is different and this action is very hard to notice. Can @miukimiu or someone recommend a solution for the charts team?

Note: this does not appear to be an issue for line visualizations, just the bar hover color.

CC @markov00 & @alexwizp

if you look closely the right visualization is also getting the synchronized hover actions in 7.15 contrast problem (1000x524)

ghudgins avatar Aug 26 '21 13:08 ghudgins

@markov00 What is the name of the theme element for the indicator on the synchronized chart? Seems it should probably just use the same style as the one used in the hovered chart.

cchaos avatar Aug 26 '21 14:08 cchaos

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Feb 22 '22 16:02 github-actions[bot]

@markov00 Was this fixed in Charts to use the same selector/indicator as the one being hovered on?

cchaos avatar Feb 22 '22 16:02 cchaos

selector

No, it wasn't fixed in this way, we can't use a dashed line in a bar chart and vice-versa. Only an adjustment on the cursor band color can fix that problem atm.

markov00 avatar Feb 23 '22 17:02 markov00

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

github-actions[bot] avatar Aug 23 '22 00:08 github-actions[bot]