eland icon indicating copy to clipboard operation
eland copied to clipboard

Add TQDM progress bar for Jupyter Notebook pandas_to_eland() calls

Open sethmlarson opened this issue 5 years ago • 2 comments

  • https://github.com/tqdm/tqdm#ipythonjupyter-integration
  • Units are rows/s
  • Maybe hide progress bar on completion? Need to test it out first.
  • Add an option show_progressbar which defaults to None
    • If None show a progress bar only if we detect Jupyter Notebook
    • If False don't show a progress bar
    • If True show a progress bar only if we detect Jupyter Notebook (for now)

sethmlarson avatar Oct 19 '20 19:10 sethmlarson

I'll try to implement this and get a gif to show for you. 😬

V1NAY8 avatar Oct 21 '20 18:10 V1NAY8

@sethmlarson I tried an example in jupyter notebook

ezgif com-gif-maker

Need suggestion on this:

  • from tqdm.notebook import tqdm => It only works in jupyter notebook , not in jupyter lab, terminal

In jupyter lab, It throws the following: image

I had the same scenario for from tqdm.auto import tqdm

Looks like there's already an issue in tqdm

Still currently exploring different options of tqdm 😄

My Queries are:

  • Is it Ok, If we just do for jupyter notebook ?
  • For testing this, Should I go with pytest --nbval to match the output?

V1NAY8 avatar Oct 24 '20 13:10 V1NAY8