ecs-logging-nodejs icon indicating copy to clipboard operation
ecs-logging-nodejs copied to clipboard

Support field customization

Open jpage-godaddy opened this issue 1 year ago • 7 comments

Support customization of fields on a per-request basis

jpage-godaddy avatar Mar 14 '24 00:03 jpage-godaddy

💚 CLA has been signed

We've reportedly signed a contributor agreement; I'm not sure how to get it to be reflected here.

jpage-godaddy avatar Mar 25 '24 22:03 jpage-godaddy

Going to try closing and reopening

jpage-godaddy avatar Mar 26 '24 15:03 jpage-godaddy

cla/check

trentm avatar Mar 26 '24 22:03 trentm

@jpage-godaddy Regarding the CLA, my understanding is that you or someone at GoDaddy will need to send an email to [email protected] asking to add you to your corporate CLA. Per this on https://www.elastic.co/contributor-agreement

If you are a company with an existing contributor license agreement and would like to add or change the list of employees that are authorized to contribute, please email us at [email protected].

I don't know how to verify on my end whether GoDaddy has a corporate CLA. Let me know if you hit a wall here and I can start asking around.

trentm avatar Mar 26 '24 22:03 trentm

Running npm run lint:fix will fix the "lint" check failure.

You'll have to avoid the ??= syntax in the test to maintain the support back to node v10 that we currently support:

/home/runner/work/ecs-logging-nodejs/ecs-logging-nodejs/packages/ecs-morgan-format/test/basic.test.js:249
        fields.labels ??= {};
                      ^^^

SyntaxError: Unexpected token '??='
    at wrapSafe (internal/modules/cjs/loader.js:1029:16)
    ...

trentm avatar Mar 26 '24 23:03 trentm

@trentm thanks for the review. I've made some updates and am ready for another pass.

jpage-godaddy avatar Apr 02 '24 19:04 jpage-godaddy