ecs-dotnet icon indicating copy to clipboard operation
ecs-dotnet copied to clipboard

EcsJsonConfiguration - With converters to protect against bad types

Open snakefoot opened this issue 3 years ago • 2 comments

Trying resolve #219

snakefoot avatar Sep 10 '22 10:09 snakefoot

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-16T18:54:20.240+0000

  • Duration: 18 min 49 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 186
Skipped 2
Total 188

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Sep 10 '22 10:09 apmmachine

Jenkins run tests please

Mpdreamz avatar Sep 12 '22 08:09 Mpdreamz

@Mpdreamz Merge conflicts now resolved

snakefoot avatar Jan 16 '23 17:01 snakefoot

Thanks @snakefoot!

I ammended this PR to improve the overall safety MetadataDictionaryConverter. Ensuring an exception during the writing of a key's value does not fail to write the whole log.

Serialization failures are now stashed under metadata.__failures__.

Also made sure NLog tests flushes the logs to XUnit's Test Output so they can be easily inspected in test runners.

Mpdreamz avatar Jan 16 '23 18:01 Mpdreamz

Jenkins run tests please

Mpdreamz avatar Jan 16 '23 18:01 Mpdreamz