ecs-dotnet
ecs-dotnet copied to clipboard
fix: deserialize nested json
BaseJsonConverter was throwing an error "Error: Exception occurred while processing event The converter 'Elastic.CommonSchema.Serialization.BaseJsonConverter' read too much or not enough." when trying to deserialize a nested json.
So adding in code fix to handle reading nested json.
💚 CLA has been signed
:grey_exclamation: Build Aborted
The PR is not allowed to run in the CI yet
the below badges are clickable and redirect to their specific view in the CI or DOCS
![]()
![]()
![]()
![]()
Expand to view the summary
Build stats
-
Start Time: 2022-08-05T00:17:20.618+0000
-
Duration: 1 min 37 sec
Steps errors 
Expand to view the steps failures
Load a resource file from a shared library
- Took 0 min 0 sec . View more details here
- Description:
approval-list/elastic/ecs-dotnet.yml
Error signal
- Took 0 min 0 sec . View more details here
- Description:
githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/santhoshar-bt return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/santhoshar-bt : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/santhoshar-bt : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}
:robot: GitHub comments
To re-run your PR in the CI, just comment with:
runelasticsearch-ci/docs: Re-trigger the docs validation. (use unformatted text in the comment!)
run elasticsearch-ci/docs
Hi @santhoshar-bt thank you for the PR can you describe what nested json means here?
If you could include a unit test with an example of json that was breaking the serialization that would be great!
Caught this in a reproducible unit test in #254 and included a fix over there so closing this PR.
:pray: Thank you for alerting us to this @santhoshar-bt and submitting the fix!