connectors
connectors copied to clipboard
[Oracle] Add logs
Part Of https://github.com/elastic/connectors/issues/2299
Adding more logs in Oracle connector.
Log file: https://drive.google.com/file/d/1eqC6FRfm4IicdMNt2Z1Hivw6x3G-g_JC/view?usp=drive_link
Checklists
Pre-Review Checklist
- [x] this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check
config.yml.example
) - [x] this PR has a meaningful title
- [x] this PR links to all relevant github issues that it fixes or partially addresses
- [x] if there is no GH issue, please create it. Each PR should have a link to an issue
- [x] this PR has a thorough description
- [x] Tested the changes locally
- [x] Added a label for each target release version (example:
v7.13.2
,v7.14.0
,v8.0.0
)
buildkite test this
@moxarth-elastic example log file that you've attached is actually for OneDrive, can you provide proper log file?
The most useful connector logs are - which queries were actually executed by the connectors. Can you add debug logs that state which exact queries were executed? A good addition to it would be to also debug log the number of records returned by the query.
@moxarth-elastic example log file that you've attached is actually for OneDrive, can you provide proper log file?
Oops! My bad. I've updated the link.
@moxarth-elastic why did you revert the whole change? The only problem was the escaping? Now I see that log lines are inconsistent - some saytable: {table}
, some say '{table}' table
.
@moxarth-elastic why did you revert the whole change? The only problem was the escaping? Now I see that log lines are inconsistent - some say
table: {table}
, some say'{table}' table
.
Oh, I see. Let me update it.
@artem-shelkovnikov I've made the logs consistent and fixed the linter error.
This is ready for review (again)
💚 Backport PR(s) successfully created
Status | Branch | Result |
---|---|---|
✅ | 8.15 | https://github.com/elastic/connectors/pull/2864 |
This backport PR will be merged automatically after passing CI.
💚 All backports created successfully
Status | Branch | Result |
---|---|---|
✅ | 8.x |
Note: Successful backport PRs will be merged automatically after passing CI.
Questions ?
Please refer to the Backport tool documentation