connectors icon indicating copy to clipboard operation
connectors copied to clipboard

[MSSQL] Add logs

Open moxarth-elastic opened this issue 9 months ago • 3 comments

Part Of https://github.com/elastic/connectors/issues/2299

Adding more logs in MSSQL connector.

Log File: https://drive.google.com/file/d/1Rnm-tMY-ECYv1JZpj3oP9SvMljZZRxjZ/view?usp=drive_link

Checklists

Pre-Review Checklist

  • [x] this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • [x] this PR has a meaningful title
  • [x] this PR links to all relevant github issues that it fixes or partially addresses
  • [x] if there is no GH issue, please create it. Each PR should have a link to an issue
  • [x] this PR has a thorough description
  • [x] Tested the changes locally
  • [x] Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

moxarth-elastic avatar May 08 '24 12:05 moxarth-elastic

buildkite test this

moxarth-elastic avatar May 08 '24 13:05 moxarth-elastic

Copying from another PR - that's applicable to all SQL connectors:

The most useful connector logs are - which queries were actually executed by the connectors. Can you add debug logs that state which exact queries were executed? A good addition to it would be to also debug log the number of records returned by the query.

artem-shelkovnikov avatar May 10 '24 15:05 artem-shelkovnikov

buildkite test this

moxarth-elastic avatar May 13 '24 09:05 moxarth-elastic

buildkite test this

moxarth-elastic avatar May 22 '24 05:05 moxarth-elastic

@moxarth-elastic I'll be taking over this and some other PRs reviewed by me to finish the work

artem-shelkovnikov avatar May 28 '24 16:05 artem-shelkovnikov

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error: There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run: backport --pr 2527 --autoMerge --autoMergeMethod squash

github-actions[bot] avatar May 28 '24 16:05 github-actions[bot]