connectors icon indicating copy to clipboard operation
connectors copied to clipboard

Create a class for RichConfigurableFields

Open seanstory opened this issue 2 years ago • 4 comments

Problem Description

It's been noted that RCF's rely on "magic strings" instead of enums or properties that clearly define which fields should be set for new configurations and should be evaluated in logic that handles the configuration objects. In fact, we rarely handle them as "objects" but instead as python dicts. This could be more object-oriented.

Proposed Solution

  • [ ] introduce a class for RichConfigurableField
  • [ ] have it define constants or enums for the fields it requires
  • [ ] replace "magic string" usages of strings like "value" and "default_value" etc with constant/enum usage

seanstory avatar Sep 22 '23 15:09 seanstory

can i work on this?

nick2432 avatar Jun 10 '24 11:06 nick2432

Absolutely! Make sure you've read through https://github.com/elastic/connectors/blob/main/docs/CONTRIBUTING.md so you know what you're getting into. But our team welcomes external contributions! Go ahead and assign yourself the issue if you want to claim it.

If you do put in the work, make sure you've registered with the Elastic Contributor Program to get rewards! https://www.elastic.co/community/contributor

seanstory avatar Jun 10 '24 15:06 seanstory

I don't see this assigned to anyone if there is no work done behind the scenes for the same can i pick this @seanstory

srinchow avatar Jun 22 '24 18:06 srinchow

Go for it! Same guidance as above. :)

seanstory avatar Jun 24 '24 15:06 seanstory