cloudbeat icon indicating copy to clipboard operation
cloudbeat copied to clipboard

Enrich GCP asset types with multiple values

Open orouz opened this issue 9 months ago • 3 comments

Summary of your changes

  1. modifies ECS types that accept a keyword from string to []string
  2. adds cloud run enricher
  3. adds utility function to traverse maps/arrays and collect leaf string values
  4. improves testing to account for all enrichers

with this PR, all asset types required for GA are fetched and enriched plus additional enrichments we may want to include next would be easy to collect.

Screenshot/Data

Screenshot 2025-02-18 at 13 16 37

Related Issues

  • closes https://github.com/elastic/cloudbeat/issues/3018

orouz avatar Feb 17 '25 10:02 orouz

This pull request does not have a backport label. Could you fix it @orouz? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major. NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

mergify[bot] avatar Feb 17 '25 10:02 mergify[bot]

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp_asset_path_values upstream/gcp_asset_path_values
git merge upstream/main
git push upstream gcp_asset_path_values

mergify[bot] avatar Feb 27 '25 14:02 mergify[bot]

One more thing - it probably needs backport-v9.x label as well.

kubasobon avatar Feb 27 '25 21:02 kubasobon