cloudbeat icon indicating copy to clipboard operation
cloudbeat copied to clipboard

Fix GCP deployment manager formatting

Open orouz opened this issue 1 year ago • 1 comments

Summary of your changes

there were 2 issues preventing GCP CSPM on agentless from successfully deploying a service account for organizations. the first was a slightly off copy-paste command in kibana which ended up not passing ORG_ID to the deployment script, so the deployment assumed it's for a project. the second issue, after providing ORG_ID, the deployment script complained about it being a number and not a string (as per its schema). this is what this PR fixes.

after fixing both of these, i've deployed GCP CSPM on agentless and got findings for an organization account:

Screenshot/Data

Screenshot 2024-09-15 at 17 59 46

Related Issues

  • fixes https://github.com/elastic/cloudbeat/issues/2502

orouz avatar Sep 15 '24 15:09 orouz

This pull request does not have a backport label. Could you fix it @orouz? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

mergify[bot] avatar Sep 15 '24 15:09 mergify[bot]

for some reason there is a bit of flakiness in service account deployments which i can't exactly pin

orouz avatar Sep 29 '24 16:09 orouz