beats icon indicating copy to clipboard operation
beats copied to clipboard

cleanup(otel): move otelbeat packages to x-pack/otel

Open mauri870 opened this issue 3 weeks ago • 14 comments

Proposed commit message

Move the remaining otelbeat packages to x-pack/otel so that all otel-related code is centralized.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool.

How to test this PR locally

cd x-pack/filebeat
mage goIntegTest

cd x-pack/metricbeat
mage goIntegTest

Related issues

  • Relates https://github.com/elastic/beats/pull/47338
  • Relates https://github.com/elastic/beats/pull/47772
  • Relates https://github.com/elastic/beats/pull/47804
  • Closes https://github.com/elastic/ingest-dev/issues/6207

mauri870 avatar Dec 02 '25 20:12 mauri870

:robot: GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

github-actions[bot] avatar Dec 02 '25 20:12 github-actions[bot]

/test

mauri870 avatar Dec 03 '25 11:12 mauri870

/test

mauri870 avatar Dec 03 '25 12:12 mauri870

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Dec 03 '25 12:12 elasticmachine

Some intermittent agent lost failures are occurring in CI. It seems to be a widespread issue on Buildkite.

mauri870 avatar Dec 03 '25 13:12 mauri870

/test

mauri870 avatar Dec 03 '25 14:12 mauri870

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

elasticmachine avatar Dec 04 '25 07:12 elasticmachine

@narph we will need someone from your team to review here please.

pierrehilbert avatar Dec 04 '25 07:12 pierrehilbert

Moving to draft until I can fix the conflicts.

mauri870 avatar Dec 09 '25 14:12 mauri870

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rellocate-xpack-otel upstream/rellocate-xpack-otel
git merge upstream/main
git push upstream rellocate-xpack-otel

mergify[bot] avatar Dec 09 '25 14:12 mergify[bot]

/test

mauri870 avatar Dec 10 '25 11:12 mauri870

/test

mauri870 avatar Dec 10 '25 20:12 mauri870

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rellocate-xpack-otel upstream/rellocate-xpack-otel
git merge upstream/main
git push upstream rellocate-xpack-otel

mergify[bot] avatar Dec 11 '25 15:12 mergify[bot]

There's something causing CI to break. The x-pack/otel: run check step normally takes less than six minutes, but it's losing the agent around the 19-minute mark:

make -C x-pack/otel check && make check-no-changes
...
go: downloading github.com/Azure/go-autorest/autorest/validation v0.3.1
go: downloading github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
go: downloading github.com/kylelemons/godebug v1.1.0
Exited with status -1 (agent lost)

I ran the same command locally and it works, so I need to check which change in this PR caused the issue.

mauri870 avatar Dec 11 '25 16:12 mauri870

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rellocate-xpack-otel upstream/rellocate-xpack-otel
git merge upstream/main
git push upstream rellocate-xpack-otel

mergify[bot] avatar Dec 16 '25 04:12 mergify[bot]