beats icon indicating copy to clipboard operation
beats copied to clipboard

[9.1](backport #47729) remove otel.component.id and otel.component.kind fields from beat receivers

Open mergify[bot] opened this issue 1 month ago • 7 comments

Proposed commit message

remove otel.component.id and otel.component.kind from events that were generated by beat receivers.

The cost of sending the extra data in every event was found to be not worth the value of having the fields.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • [x] I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

If anyone was using the fields to track beat receiver events, they won't be available anymore. However, the fields we not documented publicly and were not part of an API.

Author's Checklist

  • [ ]

How to test this PR locally

cd x-pack/filebeat/fbreceiver
go test .
cd x-pack/metricbeat/mbreceiver
go test .
cd x-pack/libbeat/outputs/otelconsumer
go test .

Related issues

  • Closes #47600

Use cases

Screenshots

Logs


This is an automatic backport of pull request #47729 done by [Mergify](https://mergify.com).

mergify[bot] avatar Nov 25 '25 20:11 mergify[bot]

Cherry-pick of ca1c17bca6ad79874ff8ebf0c1177bf516980337 has failed:

On branch mergify/bp/9.1/pr-47729
Your branch is up to date with 'origin/9.1'.

You are currently cherry-picking commit ca1c17bca.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1763578431-remove-otel.component.id-and-otel.component.kind-from-beat-receiver-events.yaml
	modified:   x-pack/filebeat/fbreceiver/receiver_test.go
	modified:   x-pack/metricbeat/tests/integration/otel_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   x-pack/filebeat/input/gcppubsub/otel_test.go
	deleted by us:   x-pack/filebeat/tests/integration/otel_lsexporter_test.go
	both modified:   x-pack/filebeat/tests/integration/otel_test.go
	both modified:   x-pack/libbeat/outputs/otelconsumer/otelconsumer.go
	both modified:   x-pack/libbeat/outputs/otelconsumer/otelconsumer_test.go
	both modified:   x-pack/metricbeat/mbreceiver/receiver_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify[bot] avatar Nov 25 '25 20:11 mergify[bot]

:robot: GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

github-actions[bot] avatar Nov 25 '25 20:11 github-actions[bot]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Nov 25 '25 20:11 elasticmachine

@leehinman I see the build is green, can we merge this?

mauri870 avatar Nov 27 '25 12:11 mauri870

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/9.1/pr-47729 upstream/mergify/bp/9.1/pr-47729
git merge upstream/9.1
git push upstream mergify/bp/9.1/pr-47729

mergify[bot] avatar Nov 27 '25 21:11 mergify[bot]

This pull request has not been merged yet. Could you please review and merge it @leehinman? 🙏

mergify[bot] avatar Dec 01 '25 05:12 mergify[bot]

This pull request has not been merged yet. Could you please review and merge it @leehinman? 🙏

mergify[bot] avatar Dec 08 '25 05:12 mergify[bot]

This pull request has not been merged yet. Could you please review and merge it @leehinman? 🙏

mergify[bot] avatar Dec 15 '25 05:12 mergify[bot]