beats icon indicating copy to clipboard operation
beats copied to clipboard

fix(x-pack/winlogbeat): run ingest pipeline tests on CI

Open andrewkroh opened this issue 1 month ago • 8 comments

Reviewer note: First commit contains code changes. Second commit is the generated golden file changes.

Proposed commit message

At some point the CI tests for the ingest pipeline in Winlogbeat stopped
being tested on CI because there was no linux host running the unit tests.
The unit tests for the ingest pipelines require Docker for running Elasticsearch.

This adds a new Buildkite step for x-pack/winlogbeat.
It fixes the tests that were broken.
It removes the request body from an eslegclient debug statement that was very
noisy, and in some cases extremely lengthy.
It removes the deprecated 'version' from the docker-compose.yaml file used to run ES.

The pipelines were mostly fine because they have been copied from elastic/integrations
where they are independently tested.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

andrewkroh avatar Oct 29 '25 19:10 andrewkroh

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

github-actions[bot] avatar Oct 29 '25 19:10 github-actions[bot]

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @andrewkroh? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

mergify[bot] avatar Oct 29 '25 19:10 mergify[bot]

This pull request doesn't have a Team:<team> label.

botelastic[bot] avatar Oct 29 '25 19:10 botelastic[bot]

🔍 Preview links for changed docs

github-actions[bot] avatar Oct 29 '25 19:10 github-actions[bot]

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

elasticmachine avatar Oct 29 '25 23:10 elasticmachine

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Oct 30 '25 07:10 elasticmachine

@nfritts Your review is needed here :-)

pierrehilbert avatar Nov 12 '25 14:11 pierrehilbert

@nfritts we still need your approval here

pierrehilbert avatar Dec 08 '25 08:12 pierrehilbert