beats icon indicating copy to clipboard operation
beats copied to clipboard

Add process management code in libbeat under Apache license

Open belimawr opened this issue 5 months ago • 4 comments

This change is needed because we need to use the same code in the oss part of Filebeat, the following PR needs this job management: https://github.com/elastic/beats/pull/43368

Proposed commit message

Move/update the code from x-pack/libbeat/common/proc/job_windows.go, now it lives in libbeat/common/proc/proc_win.go and libbeat/common/proc/proc.go and contains some updates.

Osquerybeat is updated to import the new package

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] ~~I have made corresponding changes to the documentation~~
  • [ ] ~~I have made corresponding change to the default configuration files~~
  • [ ] ~~I have added tests that prove my fix is effective or that my feature works~~
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

~~## Disruptive User Impact~~ ~~## Author's Checklist~~ ~~## How to test this PR locally~~

Related issues

  • https://github.com/elastic/beats/pull/43368

~~## Use cases~~ ~~## Screenshots~~ ~~## Logs~~

belimawr avatar Jun 24 '25 14:06 belimawr

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

github-actions[bot] avatar Jun 24 '25 14:06 github-actions[bot]

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @belimawr? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

mergify[bot] avatar Jun 24 '25 14:06 mergify[bot]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Jun 24 '25 14:06 elasticmachine

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

elasticmachine avatar Jun 24 '25 15:06 elasticmachine