[metricbeat] [system] add NTP metricset

[tommyers-elastic]

Proposed commit message

Add new Network Time Protocol (NTP) metricset to the system integration.

This is a simple wrapper around an SNTP client which allows monitoring of system clock offset compared to the configured NTP server.

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[github-actions[bot]]

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify[bot]]

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @tommyers-elastic? 🙏. For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[mergify[bot]]

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b system/ntp upstream/system/ntp
git merge upstream/main
git push upstream system/ntp

[elasticmachine]

Pinging @elastic/integrations (Team:Integrations)

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[github-actions[bot]]

🔍 Preview links for changed docs

• docs/reference/metricbeat/metricbeat-metricset-system-ntp.md
• docs/reference/metricbeat/exported-fields-system.md
• docs/reference/metricbeat/metricbeat-module-system.md
• docs/reference/metricbeat/metricbeat-modules.md

[mergify[bot]]

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b system/ntp upstream/system/ntp
git merge upstream/main
git push upstream system/ntp

[tommyers-elastic]

@AndersonQ the hosts config should not be prefixed

metricbeat.modules:
  - module: system
    period: 1s
    metricsets: ["ntp"]
    hosts: ["0.pool.ntp.org", "1.pool.ntp.org"]

i'll update this - because i see now that if you configured multiple metricsets here it errors out (see output below if you also configure cpu). the NTP config needs to be namespaced.

Exiting: host parsing failed for system-cpu: hosts must be empty for system

[AndersonQ]

@AndersonQ the hosts config should not be prefixed

metricbeat.modules:
  - module: system
    period: 1s
    metricsets: ["ntp"]
    hosts: ["0.pool.ntp.org", "1.pool.ntp.org"]

i'll update this - because i see now that if you configured multiple metricsets here it errors out (see output below if you also configure cpu). the NTP config needs to be namespaced.

Exiting: host parsing failed for system-cpu: hosts must be empty for system

ok, let me know when it's ready for re-review

[tommyers-elastic]

@AndersonQ we should be good to go