beats icon indicating copy to clipboard operation
beats copied to clipboard

[test][metricbeat] Fix system cpuinfo metricset tests on non-amd64 platforms

Open jonathan-albrecht-ibm opened this issue 5 months ago • 7 comments

Proposed commit message

[test][metricbeat] Fix system cpuinfo metricset tests on non-amd64 platforms

Checklist

  • [x ] My code follows the style guidelines of this project
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ ] ~~I have made corresponding changes to the documentation~~
  • [ ] ~~I have made corresponding change to the default configuration files~~
  • [ ] ~~I have added tests that prove my fix is effective or that my feature works~~
  • [ ] ~~I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.~~

Disruptive User Impact

None

Author's Checklist

  • [ ]

How to test this PR locally

Part of existing python tests

Related issues

  • Closes #34244

Use cases

Screenshots

Logs

jonathan-albrecht-ibm avatar Jun 12 '25 13:06 jonathan-albrecht-ibm

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

github-actions[bot] avatar Jun 12 '25 13:06 github-actions[bot]

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @jonathan-albrecht-ibm? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

mergify[bot] avatar Jun 12 '25 13:06 mergify[bot]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Jun 17 '25 07:06 elasticmachine

/test

mauri870 avatar Jun 23 '25 16:06 mauri870

@jonathan-albrecht-ibm Thanks! Can you run make check and commit the changes to the python file? It looks like CI is probably failing on some formatting requirements.

faec avatar Jun 23 '25 16:06 faec

Thanks @mauri870 and @faec. I have fixed the formatting.

jonathan-albrecht-ibm avatar Jun 23 '25 17:06 jonathan-albrecht-ibm

/test

pierrehilbert avatar Jun 24 '25 07:06 pierrehilbert

Thanks!

faec avatar Jun 25 '25 18:06 faec

Thanks for reviewing @mauri870 @andrzej-stencel @faec !

jonathan-albrecht-ibm avatar Jun 25 '25 19:06 jonathan-albrecht-ibm