beats icon indicating copy to clipboard operation
beats copied to clipboard

Remove functionbeat binaries

Open jlind23 opened this issue 1 year ago • 10 comments

Functionbeat has now been fully deprecated but binaries are still shipped as part of the standard release process, those should be removed.

cc @strawgate @nimarezainia

  • [ ] Remove functionbeat binaries starting from version 9.0
  • [ ] Remove functionbeat source code starting from version 9.0

jlind23 avatar Sep 11 '24 05:09 jlind23

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

elasticmachine avatar Sep 11 '24 05:09 elasticmachine

After chatting with @nimarezainia today we are wondering which one of the approach we should pick:

  • Removing Functionbeat binary and deleting this download page - https://www.elastic.co/downloads/beats/functionbeat
  • Keeping Functionbeat binary but highlighting that this is EOL on the download page itself
  • Switching Functionbeat download page and point to the serverless forwarder download page

@cmacknz @amitkanfer @strawgate any thoughts?

jlind23 avatar Sep 11 '24 05:09 jlind23

Switching Functionbeat download page and point to the serverless forwarder download page

Maybe this, and then add a paragraph on the serverless forwarder page that talk about Functionbeat deprecation and a link to an archive?

amitkanfer avatar Sep 11 '24 18:09 amitkanfer

Maybe this, and then add a paragraph on the serverless forwarder page that talk about Functionbeat deprecation and a link to an archive?

What would be the benefit of mentioning Functionbeat in the Serverless forwarder page?

Switching Functionbeat download page and point to the serverless forwarder download page

@nimarezainia do you know who could help us to that? I guess the team in charge of the release pages?

jlind23 avatar Sep 12 '24 07:09 jlind23

@jlind23 i'll take care of it. I suppose we need to remove the DRA also?

nimarezainia avatar Sep 12 '24 07:09 nimarezainia

I suppose we need to remove the DRA also?

So you mean that we don't want to push binaries anymore?

jlind23 avatar Sep 12 '24 07:09 jlind23

The least disruptive option is to remove the binaries completely in 9.0 and keep them around on 8.x.

If we can I would completely delete the functionbeat source code in the 9.0 branch, with it only existing in 8.x.

cmacknz avatar Sep 12 '24 16:09 cmacknz

Thanks @cmacknz, added the two related actions in the description.

jlind23 avatar Sep 12 '24 17:09 jlind23

Thanks @cmacknz, added the two related actions in the description.

Just to clarify - target removal of the download page at 9.0 as well?

nimarezainia avatar Sep 13 '24 01:09 nimarezainia

Just to clarify - target removal of the download page at 9.0 as well?

Yes.

jlind23 avatar Sep 13 '24 05:09 jlind23

After discussing with @AndersonQ, this issue is a Small in terms of work but requires sync with other teams and to have things in motion so could take more than the sprint to have it through the finish line.

pierrehilbert avatar Nov 05 '24 11:11 pierrehilbert

As it's clear on the beats PR for this issue, removing function betas also affects Kibana. One of the affected features is the ability to track telemetry regarding functionbeat as Abdul Zahid pointed out here. Those were not removed for now. I myself believe we can keep them, but ultimately it's a product decision. So @strawgate @nimarezainia as you two are in cc for this issue, I believe you might be able to help me here in deciding if we should keep or not the tracking of functionbeat telemetry in 9.0.

cc: @pierrehilbert @cmacknz

AndersonQ avatar Dec 04 '24 10:12 AndersonQ

As it's clear on the beats PR for this issue, removing function betas also affects Kibana. One of the affected features is the ability to track telemetry regarding functionbeat as Abdul Zahid pointed out here. Those were not removed for now. I myself believe we can keep them, but ultimately it's a product decision. So @strawgate @nimarezainia as you two are in cc for this issue, I believe you might be able to help me here in deciding if we should keep or not the tracking of functionbeat telemetry in 9.0.

cc: @pierrehilbert @cmacknz

keeping the tracking telemetry in there is fine IMO.

nimarezainia avatar Dec 05 '24 00:12 nimarezainia

@nimarezainia @AndersonQ as we decided to keep telemetry, are we good to close this issue as done?

jlind23 avatar Dec 09 '24 07:12 jlind23

@nimarezainia @AndersonQ as we decided to keep telemetry, are we good to close this issue as done?

sure. when the PR is merged.

nimarezainia avatar Dec 10 '24 00:12 nimarezainia