beats icon indicating copy to clipboard operation
beats copied to clipboard

Bug: fix slice init length

Open dufucun opened this issue 1 year ago • 24 comments

Proposed commit message

fix slice init length

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

dufucun avatar Aug 28 '24 08:08 dufucun

💚 CLA has been signed

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @dufucun? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Aug 28 '24 08:08 mergify[bot]

❌ Author of the following commits did not sign a Contributor Agreement: 14cb6ed

Please, read and sign the above mentioned agreement if you want to contribute to this project

signed

dufucun avatar Aug 28 '24 09:08 dufucun

Thanks!

mauri870 avatar Aug 28 '24 11:08 mauri870

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Aug 28 '24 11:08 elasticmachine

Thanks for your review!

dufucun avatar Aug 28 '24 13:08 dufucun

/test

pierrehilbert avatar Aug 30 '24 16:08 pierrehilbert

run docs-build

pierrehilbert avatar Aug 30 '24 16:08 pierrehilbert

backport-8.x has been added to help with the transition to the new branch 8.x.

mergify[bot] avatar Sep 11 '24 11:09 mergify[bot]

@dufucun, it looks like the linter is complaining about this:

  Error: libbeat/processors/ratelimit/limit.go:49:41: SA1030: 'bitSize' argument is invalid, must be either 32 or 64 (staticcheck)
  	v, err := strconv.ParseFloat(valueStr, 8)
  	                                       ^
  
  Error: issues found
  Ran golangci-lint in 429865ms

ycombinator avatar Sep 11 '24 14:09 ycombinator

@ycombinator The linter error should be fixed once https://github.com/elastic/beats/pull/40753 is merged.

Edit: I just merged the PR and rebased this branch.

mauri870 avatar Sep 11 '24 21:09 mauri870

buildkite test this

ycombinator avatar Sep 12 '24 14:09 ycombinator

buildkite test this

ycombinator avatar Sep 13 '24 13:09 ycombinator

/test

pierrehilbert avatar Sep 16 '24 07:09 pierrehilbert

run docs-build

pierrehilbert avatar Sep 16 '24 07:09 pierrehilbert

/test

pierrehilbert avatar Sep 19 '24 12:09 pierrehilbert

run docs-build

pierrehilbert avatar Sep 19 '24 12:09 pierrehilbert

/test

pierrehilbert avatar Sep 30 '24 12:09 pierrehilbert

run docs-build

pierrehilbert avatar Sep 30 '24 12:09 pierrehilbert

Would be good to get this merged. The changes are very simple and logically correct. The CI errors in the previous builds appear to be unrelated with the changes.

mauri870 avatar Oct 11 '24 15:10 mauri870

/test

pierrehilbert avatar Oct 11 '24 15:10 pierrehilbert

run docs-build

pierrehilbert avatar Oct 11 '24 15:10 pierrehilbert

Thanks

dufucun avatar Oct 16 '24 16:10 dufucun

/test

pierrehilbert avatar Oct 16 '24 16:10 pierrehilbert

/test

pierrehilbert avatar Nov 04 '24 12:11 pierrehilbert

run docs-build

pierrehilbert avatar Nov 04 '24 14:11 pierrehilbert

run docs-build

pierrehilbert avatar Nov 04 '24 16:11 pierrehilbert