pointer logic in syslog config results in timezone settings getting misapplied

[fearful-symmetry]

Right now, the filebeat syslog input declares a default config globally : https://github.com/elastic/beats/blob/18a7e5447a3b474f3f09f98932ff124d210067a5/filebeat/input/syslog/config.go#L58-L64 That includes a Timezone field that's a *cfgtype.Timezone pointer.

Later, we unpack a pointer to a new config value: https://github.com/elastic/beats/blob/18a7e5447a3b474f3f09f98932ff124d210067a5/filebeat/input/syslog/input.go#L127-L130

This means that if the user supplies a config with different syslog inputs with different timezones, they'll overwrite each other. Per @efd6 , NewInput() needs to return a set of default configs from a function call, and not a global.

[botelastic[bot]]

This issue doesn't have a Team:<team> label.

[botelastic[bot]]

Hi! We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!