beats icon indicating copy to clipboard operation
beats copied to clipboard

Enabling retries for Beats flaky tests

Open oakrizan opened this issue 1 year ago • 4 comments

Proposed commit message

In scope of beats migration from Jenkins to Buildkite - added retries to tests (Cloud tests not retried at the moment, see comment below). Packaging, K8Tests are not retried according to global Jenkinsfile. BK Builds: https://buildkite.com/elastic/beats/builds?branch=oakrizan%3Aenable-retries-for-flaky-tests

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

oakrizan avatar Apr 24 '24 09:04 oakrizan

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-01T16:52:13.394+0000

  • Duration: 14 min 45 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Apr 24 '24 09:04 elasticmachine

As per global Jenkinsfile Cloud tests are not retried. But there is no context provided why it's failure is legit, as well as not clear if that statement is still actual. As of now Cloud tests won't be retried for x-pack/filebeat & x-pack/metricbeat to align with Jenkins, but it probably needs to be revised later. cc: @dliappis @alexsapran

oakrizan avatar Apr 24 '24 14:04 oakrizan

Do I understand the PR correctly and you are adding retries to every step? (besides the ones you mentioned explicitly you are not)

alexsapran avatar Apr 26 '24 09:04 alexsapran

Do I understand the PR correctly and you are adding retries to every step? (besides the ones you mentioned explicitly you are not)

I have added retries to same steps as it is in Jenkins.

oakrizan avatar Apr 26 '24 14:04 oakrizan

/test

oakrizan avatar May 01 '24 10:05 oakrizan