beats icon indicating copy to clipboard operation
beats copied to clipboard

github-action: support check/lint/pre-commit

Open v1v opened this issue 1 year ago • 10 comments

Proposed commit message

  • WHAT: github-action: support check/lint/pre-commit.
  • WHY: remove support in Jenkins for low-hanging fruit. It was partially done in the past in https://github.com/elastic/beats/pull/32723

Further actions

  • [ ] Update branch-protection:
    • [ ] Add pre-commit / pre-commit

Checklist

  • [x] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

v1v avatar Mar 04 '24 17:03 v1v

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @v1v? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Mar 04 '24 17:03 mergify[bot]

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 131 min 34 sec

:grey_exclamation: Flaky test report

No test was executed to be analysed.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Mar 04 '24 17:03 elasticmachine

:green_heart: Build Succeeded

History

  • :green_heart: Build #2984 succeeded 7a8d2f34b9ad1e743368195ebc39db2b3512aea2
  • :green_heart: Build #2981 succeeded 5df2fe06b8c2cf34e2900032eab9b5229d4dca21
  • :green_heart: Build #2977 succeeded b502de3d1ea7d95ee019ba440777eebfb891bd2b
  • :green_heart: Build #2976 succeeded e2b8d36a38c18c2c9ea1ae4b7eecdaa3257e6fb5

cc @v1v

elasticmachine avatar Mar 12 '24 09:03 elasticmachine

:green_heart: Build Succeeded

History

  • :green_heart: Build #1770 succeeded 7a8d2f34b9ad1e743368195ebc39db2b3512aea2
  • :green_heart: Build #1767 succeeded 5df2fe06b8c2cf34e2900032eab9b5229d4dca21
  • :green_heart: Build #1763 succeeded b502de3d1ea7d95ee019ba440777eebfb891bd2b
  • :green_heart: Build #1762 succeeded e2b8d36a38c18c2c9ea1ae4b7eecdaa3257e6fb5

cc @v1v

elasticmachine avatar Mar 12 '24 09:03 elasticmachine

:green_heart: Build Succeeded

History

  • :green_heart: Build #1777 succeeded 7a8d2f34b9ad1e743368195ebc39db2b3512aea2
  • :green_heart: Build #1774 succeeded 5df2fe06b8c2cf34e2900032eab9b5229d4dca21
  • :green_heart: Build #1770 succeeded b502de3d1ea7d95ee019ba440777eebfb891bd2b
  • :green_heart: Build #1769 succeeded e2b8d36a38c18c2c9ea1ae4b7eecdaa3257e6fb5

cc @v1v

elasticmachine avatar Mar 12 '24 09:03 elasticmachine

:green_heart: Build Succeeded

History

  • :green_heart: Build #933 succeeded 7a8d2f34b9ad1e743368195ebc39db2b3512aea2
  • :green_heart: Build #930 succeeded 5df2fe06b8c2cf34e2900032eab9b5229d4dca21
  • :green_heart: Build #926 succeeded b502de3d1ea7d95ee019ba440777eebfb891bd2b
  • :green_heart: Build #925 succeeded e2b8d36a38c18c2c9ea1ae4b7eecdaa3257e6fb5

cc @v1v

elasticmachine avatar Mar 12 '24 09:03 elasticmachine

:broken_heart: Build Failed

Failed CI Steps

History

  • :green_heart: Build #2066 succeeded 7a8d2f34b9ad1e743368195ebc39db2b3512aea2
  • :green_heart: Build #2063 succeeded 5df2fe06b8c2cf34e2900032eab9b5229d4dca21

cc @v1v

elasticmachine avatar Mar 12 '24 09:03 elasticmachine

:broken_heart: Build Failed

Failed CI Steps

History

  • :green_heart: Build #3406 succeeded 7a8d2f34b9ad1e743368195ebc39db2b3512aea2

cc @v1v

elasticmachine avatar Mar 12 '24 09:03 elasticmachine

I don't know who has the superpower to merge, but! It will require a couple of further changes afterwards, as noted in the description.

v1v avatar Mar 14 '24 09:03 v1v

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/check-on-gh-actions upstream/feature/check-on-gh-actions
git merge upstream/main
git push upstream feature/check-on-gh-actions

mergify[bot] avatar May 15 '24 14:05 mergify[bot]

LGTM

pazone avatar Jun 04 '24 00:06 pazone