beats icon indicating copy to clipboard operation
beats copied to clipboard

Remove incorrect ES field

Open matschaffer opened this issue 3 years ago • 3 comments

What does this PR do?

Removes elasticsearch.node_stats.indices.bulk.avg_time.bytes

Why is it important?

The field doesn't exist in https://github.com/klacabane/elasticsearch/blob/fede65858555e4106027b7498f6dfda85df87c8e/x-pack/plugin/core/src/main/resources/monitoring-es-mb.json, isn't populated by the module code, also doesn't make sense that we'd have bytes under a time grouping.

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have made corresponding change to the default configuration files
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Set up from-source monitoring

Run the Elasticsearch module in default mode

http.enabled: true
http.host: "0.0.0.0"

metricbeat.modules:
  - module: elasticsearch
    period: 10s
    hosts:
      - "localhost:9200"
    username: "elastic"
    password: "changeme"

  - module: kibana
    basepath: "/ftw"
    period: 10s
    hosts: [ "localhost:5601" ]
    username: "elastic"
    password: "changeme"

output.elasticsearch:
  hosts: [ "localhost:9200" ]
  username: "elastic"
  password: "changeme"

Note lack of elasticsearch > node > stats > indices > bulk > avg_time > bytes in mappings.

Related issues

Closes https://github.com/elastic/beats/issues/33211

Use cases

Using the elasticsearch metricbeat module to monitor elasticsearch in non-xpack mode.

matschaffer avatar Oct 06 '22 05:10 matschaffer

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @matschaffer? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Oct 06 '22 05:10 mergify[bot]

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T02:30:56.531+0000

  • Duration: 49 min 38 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 3883
Skipped 884
Total 4767

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Oct 06 '22 05:10 elasticmachine

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 33211-update-es-mappings upstream/33211-update-es-mappings
git merge upstream/main
git push upstream 33211-update-es-mappings

mergify[bot] avatar Oct 06 '22 08:10 mergify[bot]