beats icon indicating copy to clipboard operation
beats copied to clipboard

Add not dedoted k8s pod labels in autodiscover provider to be used for templating, exactly like annotations

Open MichaelKatsoulis opened this issue 2 years ago • 3 comments

What does this PR do?

Continuation of https://github.com/elastic/elastic-agent/pull/1398 for kubernetes autodiscover provider used in beats.

Why is it important?

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Logs

MichaelKatsoulis avatar Oct 03 '22 14:10 MichaelKatsoulis

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @MichaelKatsoulis? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Oct 03 '22 14:10 mergify[bot]

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-10T13:14:07.592+0000

  • Duration: 115 min 5 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 23636
Skipped 1950
Total 25586

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Oct 03 '22 15:10 elasticmachine

I need to fix the tests first!

MichaelKatsoulis avatar Oct 04 '22 08:10 MichaelKatsoulis