beats icon indicating copy to clipboard operation
beats copied to clipboard

[Heartbeat] fix minor unreachable code

Open Abirdcfly opened this issue 3 years ago • 4 comments

Signed-off-by: Abirdcfly [email protected]

  • Cleanup

What does this PR do?

Why is it important?

Checklist

  • [x] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Abirdcfly avatar Aug 11 '22 08:08 Abirdcfly

💚 CLA has been signed

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-11T11:28:49.014+0000

  • Duration: 75 min 4 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 6794
Skipped 737
Total 7531

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Aug 11 '22 08:08 elasticmachine

@Abirdcfly Please add an error check to the os.MkdirAll call. Otherwise LGTM

Done for make golangci-lint happy.

Abirdcfly avatar Aug 11 '22 11:08 Abirdcfly

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @Abirdcfly? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change) To fixup this pull request, you need to add the backport labels for the needed branches, such as:
  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Aug 16 '22 15:08 mergify[bot]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

elasticmachine avatar Aug 16 '22 19:08 elasticmachine

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Aug 16 '22 19:08 elasticmachine

@cmacknz Are you able to take a look at this?

epixa avatar Sep 07 '22 01:09 epixa

Didn't realize I was holding this up. Approved, and merged. Thanks!

cmacknz avatar Sep 07 '22 16:09 cmacknz