beats icon indicating copy to clipboard operation
beats copied to clipboard

[MetricBeat] Add aws autoscaling group metricset.

Open kwinstonix opened this issue 3 years ago • 4 comments

What does this PR do?

Add AWS autoscaling module in metricbeat.

Why is it important?

AWS resource groups API doesn't support AutoScaling Group resource, so cloudwatch metricset can't fetch the tags of AutoScaling Group. We should use DescribeAutoScalingGroups API instead.

https://docs.aws.amazon.com/ARG/latest/userguide/supported-resources.html

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

  • close #31303

kwinstonix avatar Aug 09 '22 13:08 kwinstonix

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-09T13:26:56.755+0000

  • Duration: 5 min 8 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a shared library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/beats.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/kwinstonix return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/kwinstonix : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/kwinstonix : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Aug 09 '22 13:08 elasticmachine

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @kwinstonix? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change) To fixup this pull request, you need to add the backport labels for the needed branches, such as:
  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Aug 16 '22 15:08 mergify[bot]

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b aws-autoscaling-metricset upstream/aws-autoscaling-metricset
git merge upstream/main
git push upstream aws-autoscaling-metricset

mergify[bot] avatar Aug 24 '22 21:08 mergify[bot]

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b aws-autoscaling-metricset upstream/aws-autoscaling-metricset
git merge upstream/main
git push upstream aws-autoscaling-metricset

mergify[bot] avatar Sep 26 '22 06:09 mergify[bot]