beats icon indicating copy to clipboard operation
beats copied to clipboard

[Filebeat] Add Cloudflare R2 to provider list

Open legoguy1000 opened this issue 2 years ago • 4 comments

What does this PR do?

Now that Cloudflare R2 is out of closed beta, this adds their domain to the provider list to automatically detect and set the provider field.

Why is it important?

Checklist

  • [X] My code follows the style guidelines of this project
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] I have made corresponding change to the default configuration files
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

legoguy1000 avatar Aug 07 '22 14:08 legoguy1000

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T13:07:37.447+0000

  • Duration: 132 min 16 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 4346
Skipped 338
Total 4684

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Aug 07 '22 14:08 elasticmachine

/test

cmacknz avatar Aug 08 '22 13:08 cmacknz

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

elasticmachine avatar Aug 08 '22 13:08 elasticmachine

The S3 input doesn't have a codeowner listed, and I see changes from both cloud monitoring and SEI in the history. Requesting review from those teams, and we should clarify who the codeowner for this module should be if we can.

cmacknz avatar Aug 08 '22 13:08 cmacknz

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @legoguy1000? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change) To fixup this pull request, you need to add the backport labels for the needed branches, such as:
  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Aug 16 '22 15:08 mergify[bot]

Can this be merged?

legoguy1000 avatar Aug 23 '22 03:08 legoguy1000

Can someone from @elastic/obs-cloud-monitoring approve if they want to support this?

cmacknz avatar Aug 23 '22 12:08 cmacknz