beats icon indicating copy to clipboard operation
beats copied to clipboard

Make cockroachdb GA

Open ritalwar opened this issue 2 years ago • 2 comments

  • Enhancement

What does this PR do?

This PR make cockroachdb module GA.

Why is it important?

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run CockroachDB instance. Enable cockroachdb module and update cockroachdb.yml with host and port details. Start metricbeat and metrics should start flowing through ES.

Related issues

  • Relates #25622
  • Relates #19517
  • Relates https://github.com/elastic/integrations/issues/3550

ritalwar avatar Jul 27 '22 15:07 ritalwar

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T03:00:24.275+0000

  • Duration: 90 min 56 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 4095
Skipped 999
Total 5094

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar Jul 27 '22 16:07 elasticmachine

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @ritalwar? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change) To fixup this pull request, you need to add the backport labels for the needed branches, such as:
  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar Aug 16 '22 15:08 mergify[bot]

Let's use the same docker image what we have used in integrations.

ishleenk17 avatar Sep 08 '22 11:09 ishleenk17

Let's use the same docker image what we have used in integrations.

Have tested the change with different versions of CockroachDB and everything is working fine. Though updating container image here is generating some Docker issues which can be tracked later in: https://github.com/elastic/beats/issues/33115

ritalwar avatar Sep 19 '22 04:09 ritalwar