beats
beats copied to clipboard
libbeat/processors/util: make mac address rendering conform to ECS
What does this PR do?
This alters the syntax of hardware addresses to match the syntax that is specified in ECS.
Why is it important?
Currently it does not match the spec and this leaks out to integrations and modules in ways that are irritating to fix in ingest pipelines.
Checklist
- [x] My code follows the style guidelines of this project
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] ~~I have made corresponding changes to the documentation~~
- [ ] ~~I have made corresponding change to the default configuration files~~
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added an entry in
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.
Author's Checklist
- [ ]
How to test this PR locally
Related issues
- Closes #32264
Use cases
Screenshots
Logs
:green_heart: Build Succeeded
the below badges are clickable and redirect to their specific view in the CI or DOCS
![]()
![]()
![]()
![]()
![]()
Expand to view the summary
Build stats
-
Start Time: 2022-07-27T04:51:16.939+0000
-
Duration: 90 min 9 sec
Test stats :test_tube:
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 22535 |
| Skipped | 1937 |
| Total | 24472 |
:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:
-
/test: Re-trigger the build. -
/package: Generate the packages and run the E2E tests. -
/beats-tester: Run the installation tests with beats-tester. -
runelasticsearch-ci/docs: Re-trigger the docs validation. (use unformatted text in the comment!)
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)
My only hesitation with this is that it is a breaking change for anyone searching for MAC addresses. I suppose the argument for doing this is that anyone searching for MACs today would need to handle multiple possible formats already anyway since we don't standardize them.
I have the same concerns about the breaking change. The impetus for this is that the ECS specifies the format used in this change.
This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
git fetch upstream
git checkout -b 32264-libbeat upstream/32264-libbeat
git merge upstream/main
git push upstream 32264-libbeat
This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
git fetch upstream
git checkout -b 32264-libbeat upstream/32264-libbeat
git merge upstream/main
git push upstream 32264-libbeat