beats icon indicating copy to clipboard operation
beats copied to clipboard

[Spike] [Heartbeat] Explore implementing `timeout` for browser monitors

Open dominiqueclarke opened this issue 3 years ago • 4 comments

Heartbeat exposes a timeout field for monitor types. However, browser monitors do not currently support timeout and the value is ignored

We should consider implementing timeout for browser monitors, and the side-effects of doing so. In particular, we will need to determine how this logic ought to behave for both inline and zip URL monitors.

dominiqueclarke avatar Dec 15 '21 16:12 dominiqueclarke

Pinging @elastic/uptime (Team:Uptime)

elasticmachine avatar Dec 15 '21 16:12 elasticmachine

Building this correctly for inline monitors is pretty straightforward, it's a bit more complex for suites.

I propose the following:

  1. We parallelize all suite jobs, to run all journeys simultaneously
  2. We stagger the jobs by consistently hashing their journey names to run at offsets to prevent them all running at the same time, thus spreading them out over their test interval. This prevents the problem we currently have, where serially executed journeys can delay the start of one after (head of line blocking).
  3. We add the timeout value to these individual jobs
  4. After each job we send a new suite status doc per https://github.com/elastic/beats/issues/27924#issuecomment-992861432, rather than waiting till the end of the run, the suite statuses are updated once per journey completion

andrewvc avatar Dec 15 '21 18:12 andrewvc

All of this states we need ahead of time compilation for the HB especially for suites, haven't thought about how we would do this.

vigneshshanmugam avatar Dec 15 '21 20:12 vigneshshanmugam

@dominiqueclarke @andrewvc with zip url and suites being deprecated, is this still a requirement? We already have issues for timeouts to be supported at project level

emilioalvap avatar Oct 07 '22 15:10 emilioalvap

Hi! We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

botelastic[bot] avatar Oct 07 '23 16:10 botelastic[bot]

Captured in https://github.com/elastic/synthetics/issues/133, closing

paulb-elastic avatar Nov 13 '23 15:11 paulb-elastic