apm-server icon indicating copy to clipboard operation
apm-server copied to clipboard
verified publisher icon elastic

backport: Add 8.5 branch

Open elasticmachine opened this issue 3 years ago • 2 comments

Merge as soon as 8.5 branch was created. Auto-merge is not yet supported, see https://github.com/Mergifyio/mergify-engine/discussions/2821

elasticmachine avatar Sep 21 '22 13:09 elasticmachine

This pull request does not have a backport label. Could you fix it @elasticmachine? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

mergify[bot] avatar Sep 21 '22 13:09 mergify[bot]

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-23T06:35:53.333+0000

  • Duration: 35 min 48 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 148
Skipped 0
Total 148

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Sep 21 '22 13:09 apmmachine

:books: Go benchmark report

Diff with the main branch

name                                                                                              old time/op    new time/op     delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
ContextResetContentEncoding/deflate_sniff-12                                                        4.05µs ± 5%     2.92µs ±51%   -27.94%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                                    186µs ±21%      119µs ±22%   -35.88%  (p=0.008 n=5+5)
BackendProcessor/otel-bridge.ndjson-12                                                              43.3µs ±19%     15.0µs ± 4%   -65.33%  (p=0.008 n=5+5)
BackendProcessor/transactions_spans_rum_2.ndjson-12                                                 22.9µs ±20%     14.9µs ±47%   -35.24%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/invalid-json-event.ndjson-12            3.84µs ± 4%     3.70µs ± 4%    -3.53%  (p=0.048 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/span-links.ndjson-12                    4.01µs ± 3%     3.87µs ± 2%    -3.43%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/errors.ndjson-12                        8.56µs ± 1%     8.71µs ± 2%    +1.75%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/minimal.ndjson-12                       2.33µs ± 0%     2.53µs ± 5%    +8.45%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/optional-timestamps.ndjson-12           1.83µs ± 5%     1.92µs ± 2%    +5.09%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/otel-bridge.ndjson-12                   3.92µs ± 1%     3.97µs ± 1%    +1.18%  (p=0.016 n=5+4)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/ratelimit.ndjson-12                     6.63µs ± 2%     7.14µs ±10%    +7.64%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/spans.ndjson-12                         11.5µs ± 1%     12.0µs ± 4%    +3.87%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                  11.3µs ± 0%     11.5µs ± 2%    +1.36%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12            11.2µs ± 1%     11.6µs ± 3%    +3.45%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12      2.00µs ± 1%     2.09µs ± 6%    +4.34%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                      7.66µs ± 1%     7.88µs ± 7%    +2.97%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12       5.58µs ± 1%     5.83µs ± 4%    +4.56%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                      13.6µs ± 1%     14.1µs ± 6%    +3.63%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/logs.ndjson-12                        1.95µs ± 1%     2.03µs ±11%    +4.29%  (p=0.040 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                  4.51µs ± 1%     4.65µs ± 4%    +3.09%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                 3.26µs ± 1%     3.41µs ± 8%    +4.65%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12    1.56µs ± 1%     1.65µs ± 8%    +5.80%  (p=0.016 n=5+5)
ReadBatch/errors_rum.ndjson-12                                                                      31.0µs ±12%     23.3µs ±32%   -24.94%  (p=0.032 n=5+5)
ReadBatch/invalid-event-type.ndjson-12                                                              11.7µs ±17%      7.1µs ±39%   -39.05%  (p=0.016 n=5+5)
ReadBatch/invalid-metadata.ndjson-12                                                                28.4µs ±18%     20.8µs ±28%   -27.00%  (p=0.016 n=5+5)
ReadBatch/otel-bridge.ndjson-12                                                                     39.2µs ±16%     29.3µs ±33%   -25.42%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/nop_codec/1000_events-12                                                                 1.00ms ± 6%     0.93ms ± 9%    -7.23%  (p=0.032 n=5+5)

name                                                                                              old alloc/op   new alloc/op    delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/invalid-event-type.ndjson-12                                                       3.54kB ± 2%     3.61kB ± 2%    +1.79%  (p=0.040 n=5+5)
BackendProcessor/invalid-metadata-2.ndjson-12                                                       2.73kB ± 2%     2.68kB ± 1%    -1.74%  (p=0.032 n=5+5)
BackendProcessor/transactions_spans.ndjson-12                                                       23.9kB ± 1%     24.2kB ± 1%    +1.03%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/span-links.ndjson-12                    5.16kB ± 2%     5.22kB ± 1%    +1.26%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/unknown-span-type.ndjson-12             18.5kB ± 1%     18.7kB ± 1%    +1.21%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-metadata-2.ndjson-12            3.23kB ± 1%     3.18kB ± 1%    -1.61%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/errors_rum.ndjson-12                    8.37kB ± 1%     8.30kB ± 1%    -0.90%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-event-type.ndjson-12            4.22kB ± 2%     4.15kB ± 1%    -1.71%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/span-links.ndjson-12                  5.18kB ± 1%     5.08kB ± 3%    -2.02%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/spans.ndjson-12                       29.7kB ± 1%     29.3kB ± 1%    -1.37%  (p=0.008 n=5+5)
ReadBatch/optional-timestamps.ndjson-12                                                             3.62kB ± 0%     3.62kB ± 0%    -0.06%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/json_codec/1000_events-12                                                                3.46MB ± 0%     3.44MB ± 0%    -0.48%  (p=0.016 n=5+4)
ReadEvents/json_codec_big_tx/199_events-12                                                          1.42MB ± 0%     1.43MB ± 0%    +0.05%  (p=0.024 n=5+5)

name                                                                                              old allocs/op  new allocs/op   delta
pkg:github.com/elastic/apm-server/internal/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/beater/request goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/internal/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                              old speed      new speed       delta
pkg:github.com/elastic/apm-server/internal/processor/stream goos:linux goarch:amd64
BackendProcessor/events.ndjson-12                                                                 40.9MB/s ±24%   63.6MB/s ±22%   +55.32%  (p=0.008 n=5+5)
BackendProcessor/otel-bridge.ndjson-12                                                            44.2MB/s ±18%  125.3MB/s ± 4%  +183.36%  (p=0.008 n=5+5)
BackendProcessor/transactions_spans_rum_2.ndjson-12                                               49.5MB/s ±23%   85.5MB/s ±45%   +72.74%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/span-links.ndjson-12                   170MB/s ± 3%    176MB/s ± 2%    +3.56%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/errors.ndjson-12                       741MB/s ± 1%    728MB/s ± 2%    -1.71%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/minimal.ndjson-12                      442MB/s ± 0%    408MB/s ± 4%    -7.74%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/optional-timestamps.ndjson-12          561MB/s ± 5%    534MB/s ± 2%    -4.89%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/otel-bridge.ndjson-12                  479MB/s ± 1%    474MB/s ± 1%    -1.15%  (p=0.016 n=5+4)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/ratelimit.ndjson-12                    635MB/s ± 2%    593MB/s ± 9%    -6.69%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/spans.ndjson-12                        696MB/s ± 1%    670MB/s ± 4%    -3.68%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions.ndjson-12                 498MB/s ± 0%    492MB/s ± 2%    -1.33%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans.ndjson-12           519MB/s ± 1%    502MB/s ± 3%    -3.31%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/transactions_spans_rum_2.ndjson-12     558MB/s ± 1%    536MB/s ± 6%    -4.04%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors.ndjson-12                     829MB/s ± 1%    806MB/s ± 7%    -2.75%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/errors_transaction_id.ndjson-12      685MB/s ± 1%    656MB/s ± 4%    -4.28%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/events.ndjson-12                     548MB/s ± 1%    529MB/s ± 5%    -3.43%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/metricsets.ndjson-12                 564MB/s ± 1%    547MB/s ± 4%    -2.96%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/otel-bridge.ndjson-12                577MB/s ± 1%    552MB/s ± 8%    -4.27%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel200/transactions_spans_rum_2.ndjson-12   717MB/s ± 1%    679MB/s ± 8%    -5.31%  (p=0.016 n=5+5)
ReadBatch/errors_rum.ndjson-12                                                                    61.5MB/s ±13%   84.9MB/s ±31%   +37.89%  (p=0.032 n=5+5)
ReadBatch/invalid-event-type.ndjson-12                                                            33.9MB/s ±19%   57.6MB/s ±31%   +69.84%  (p=0.016 n=5+5)
ReadBatch/invalid-metadata.ndjson-12                                                              15.9MB/s ±18%   22.2MB/s ±34%   +39.77%  (p=0.016 n=5+5)
ReadBatch/otel-bridge.ndjson-12                                                                   48.4MB/s ±15%   67.1MB/s ±44%   +38.54%  (p=0.008 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

apmmachine avatar Sep 23 '22 07:09 apmmachine