apm-server icon indicating copy to clipboard operation
apm-server copied to clipboard

Sourcemap upload documentation: align curl example with custom app example

Open jin-harmoney opened this issue 3 years ago • 2 comments

Motivation/summary

The examples concerning the bundle_filepath are not in line. The goal of this PR is to align them.

The documentation mentions: bundle_filepath - The absolute path of the final bundle as used in the web application.

So I'm not sure if should now be http://localhost/app.min.js or just app.min.js? This change aligns both examples, but I'm still not 100% sure if this is fully correct. I do however know that using http://localhost/app.min.js worked when we used Elastic v7.

Checklist

  • [x] Documentation has been updated

jin-harmoney avatar Jun 22 '22 09:06 jin-harmoney

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T08:08:22.992+0000

  • Duration: 3 min 4 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a shared library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/apm-server.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/jin-harmoney return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/jin-harmoney : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/jin-harmoney : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Jun 22 '22 09:06 apmmachine

Apologies for coming back to you that late. The bundle_filepath is expected to be working also with a relative path.

simitt avatar Jul 19 '22 11:07 simitt

@jin-harmoney thanks for the PR, but as @simitt said above it's expected that a relative bundle_filepath should work. We had a bug with that which will be fixed in 8.5.0: https://github.com/elastic/apm-server/issues/8650

axw avatar Sep 29 '22 04:09 axw