apm-server icon indicating copy to clipboard operation
apm-server copied to clipboard

[systemtest] Get repo root correctly with go workspaces

Open lahsivjar opened this issue 1 year ago • 1 comments

Motivation/summary

Fixes the repo root resolution when go workspace is in use. In this case the command go list -m will list all the modules in use by the go workspace and the current getRepoRoot cannot handle it correctly.

The changes the PR proposes is also kinda hacky, happy to hear if others have a better solution to finding the repo root or fixing the issue.

Checklist

~~- [ ] Update CHANGELOG.asciidoc~~ ~~- [ ] Documentation has been updated~~

How to test these changes

  1. cd systemtest
  2. go work init
  3. go work use <path_to_apm_tools>
  4. go work use .
  5. go test -v -count=1 ./...

Tests should pass without errors.

Related issues

N/A

lahsivjar avatar Jun 06 '24 15:06 lahsivjar

This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

mergify[bot] avatar Jun 06 '24 15:06 mergify[bot]